[PHPStan ^2.1.1] Handle next unreachable statement via UnreachableStatementNode->getNextUnreachableStatements() #6642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ondrejmirtes I tried the it just needs sync on rector-* packages on next PHPStan 2.1.x version released :) |
samsonasik
force-pushed
the
use-phpstan-21xdev
branch
from
5fe6616 to
305e60f
Compare
samsonasik
changed the title
samsonasik
commented
Jan 5, 2025
| $nameResolver = new NameResolver(); | ||
| $variadicMethodsVisitor = new VariadicMethodsVisitor(); | ||
| $variadicFunctionsVisitor = new VariadicFunctionsVisitor(); | ||
| $propertyHookNameVisitor = new PropertyHookNameVisitor(); |
There was a problem hiding this comment.
@TomasVotruba on PHPStan 2.1.0, PropertyHookNameVisitor exists, but removed on PHPStan 2.1.1, this patch include it
…StatementNode->getNextUnreachableStatements()
…StatementNode->getNextUnreachableStatements()
samsonasik
force-pushed
the
use-phpstan-21xdev
branch
from
1a1427c to
c465525
Compare
|
All checks have passed 🎉 @TomasVotruba I am merging it and will release immediate release for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref Latest PHPStan PR on 2.1.1 that already include getNextUnreachableStatements on
UnreachableStatementNodenode: